Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug when API key is missing #161

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ltctceplrm
Copy link
Contributor

To fix #159.

Ideally at one point the user should be notified with a message box that he's missing an API but for now this should be good enough

Copy link
Owner

@mProjectsCode mProjectsCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to also show the user a notice, instead of just printing something to the console.

src/api/apis/OMDbAPI.ts Outdated Show resolved Hide resolved
src/api/apis/MobyGamesAPI.ts Outdated Show resolved Hide resolved
@mProjectsCode
Copy link
Owner

mProjectsCode commented Aug 22, 2024

You should construct errors with the constructor, so new Error(...) instead of Error(...). Even though we hadn't used the constructor before.

Forgot to revert searchbyid for Mobygames
So users know what went wrong without going to the console
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Videogames nolonger searchable
2 participants